Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

[RFC] Change installation for extra packages #346

Merged
merged 13 commits into from
May 30, 2021

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented May 27, 2021

What does this PR do?

We recently divided requirements into several wrt data types (e.g. pip install lightning-flash[image]), but I don't think it's intuitive to users as I left a comment in #215 (comment).

TODO

I'll update the docs and fix failing CI (if there is) once I get positive comments from core members.

  • Fix CI
  • Update installation docs

Description of the changes

Before

dev      = vision + tabular + text + image
dev-test = dev + test
all      = dev + docs

After

# for users
all = vision + tabular + text
# for Flash contributors/developers
dev = all + tests + docs

Before submitting

  • [RFC] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • [n/a] Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@akihironitta akihironitta added the enhancement New feature or request label May 27, 2021
@akihironitta
Copy link
Contributor Author

@tchaton @Borda @ethanwharris I'd love to know your thoughts on this change.

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akihironitta This looks great 😃 definitely more intuitive than before

@codecov
Copy link

codecov bot commented May 29, 2021

Codecov Report

Merging #346 (bc98837) into master (9c5dbd7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #346   +/-   ##
=======================================
  Coverage   88.82%   88.82%           
=======================================
  Files          80       80           
  Lines        4143     4143           
=======================================
  Hits         3680     3680           
  Misses        463      463           
Flag Coverage Δ
unittests 88.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c5dbd7...bc98837. Read the comment docs.

@akihironitta akihironitta marked this pull request as ready for review May 29, 2021 09:56
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just be aware that this will install only packages from pypi, no with given path/url

@justusschock
Copy link
Member

@Borda not sure about urls but afaik you can definitely do pip install "./some/path[images]"

you just need the quotation marks :)

@justusschock justusschock enabled auto-merge (squash) May 30, 2021 09:55
@ethanwharris ethanwharris disabled auto-merge May 30, 2021 12:04
@ethanwharris ethanwharris merged commit c11498d into master May 30, 2021
@ethanwharris ethanwharris deleted the feat/change-installation branch May 30, 2021 12:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants