Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

[feat] Update Segmentation Task in preparation to adding resizing #287

Merged
merged 13 commits into from
May 12, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented May 12, 2021

What does this PR do?

This PR updates the Segmentation Task and simplify the internals.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton self-assigned this May 12, 2021
@tchaton tchaton added this to the 0.3 milestone May 12, 2021
Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really cool, you found another use for state! 😃

@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #287 (bdec71f) into master (e36a250) will increase coverage by 4.11%.
The diff coverage is 88.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
+ Coverage   84.28%   88.39%   +4.11%     
==========================================
  Files          74       74              
  Lines        3577     3612      +35     
==========================================
+ Hits         3015     3193     +178     
+ Misses        562      419     -143     
Flag Coverage Δ
unittests 88.39% <88.00%> (+4.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/data/data_pipeline.py 92.75% <50.00%> (+0.39%) ⬆️
flash/vision/segmentation/serialization.py 82.22% <60.00%> (+13.33%) ⬆️
flash/data/splits.py 92.85% <88.88%> (-1.88%) ⬇️
flash/vision/segmentation/data.py 88.74% <93.10%> (+0.10%) ⬆️
flash/__init__.py 100.00% <100.00%> (ø)
flash/data/data_source.py 96.85% <100.00%> (+2.54%) ⬆️
flash/data/properties.py 83.11% <0.00%> (+1.29%) ⬆️
flash/data/data_module.py 92.34% <0.00%> (+1.43%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e36a250...bdec71f. Read the comment docs.

flash/vision/segmentation/data.py Outdated Show resolved Hide resolved
flash/vision/segmentation/data.py Outdated Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label May 12, 2021
@tchaton tchaton merged commit 41b9850 into master May 12, 2021
@tchaton tchaton deleted the postprocess branch May 12, 2021 17:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants