-
Notifications
You must be signed in to change notification settings - Fork 211
Conversation
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
==========================================
+ Coverage 86.31% 86.53% +0.21%
==========================================
Files 56 57 +1
Lines 2674 2732 +58
==========================================
+ Hits 2308 2364 +56
- Misses 366 368 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor typing and left some general comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does registering a function to multiple registries or with multiple names work properly? We should test it
Hello @tchaton! Thanks for updating this PR.
Comment last updated at 2021-04-07 23:11:56 UTC |
@@ -16,145 +29,102 @@ class FlashRegistry: | |||
|
|||
backbones = FlashRegistry("backbones") | |||
|
|||
@backbones.register_function() | |||
@backbones |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀🚀
What does this PR do?
Fixes #167
Before submitting
PR review