Add BaseViz Callback (2 / 2) #201

tchaton · 2021-03-31T17:35:18Z

What does this PR do?

Next to #200

This PR adds a BaseViz Callback which wrap the preprocess hooks and gather batches of data.

Before submitting

Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes?
Did you write any new necessary tests? [not needed for typos/docs]
Did you verify new and existing tests pass locally with your changes?
If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

codecov · 2021-03-31T17:58:14Z

Codecov Report

Merging #201 (67ba94c) into master (6e548a4) will increase coverage by 0.82%.
The diff coverage is 97.48%.

@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
+ Coverage   85.49%   86.31%   +0.82%     
==========================================
  Files          54       56       +2     
  Lines        2495     2674     +179     
==========================================
+ Hits         2133     2308     +175     
- Misses        362      366       +4

Flag	Coverage Δ
unittests	`86.31% <97.48%> (+0.82%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
flash/core/model.py	`93.71% <ø> (-0.31%)`	⬇️
flash/vision/classification/data.py	`87.92% <ø> (+0.48%)`	⬆️
flash/data/process.py	`84.86% <91.66%> (+0.36%)`	⬆️
flash/data/base_viz.py	`95.58% <95.58%> (ø)`
flash/data/data_module.py	`78.49% <97.77%> (+5.95%)`	⬆️
flash/core/utils.py	`100.00% <100.00%> (ø)`
flash/data/auto_dataset.py	`96.25% <100.00%> (+0.47%)`	⬆️
flash/data/batch.py	`79.67% <100.00%> (+2.82%)`	⬆️
flash/data/callback.py	`100.00% <100.00%> (ø)`
flash/data/data_pipeline.py	`87.36% <100.00%> (ø)`
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e548a4...67ba94c. Read the comment docs.

…tning-flash into base_viz_2

flash/core/model.py

flash/core/utils.py

flash/core/model.py

tests/data/test_data_viz.py

test.py

flash/vision/classification/data.py

carmocca · 2021-04-06T12:47:41Z

flash/data/callback.py

+        """Called after `per_batch_transform_on_device` """
+
+
+class ControlFlow(FlashCallback):


This is a bit weird to me as we don't have such thing in Lightning. We just loop over all callbacks for each hook around the code. Do you prefer this object? Why?

Yes, I prefer this object and I think we should add a similar one within Lightning. The callbacks logic should be fully managed by callbacks.

edgarriba

Minor typos and typing

flash/core/utils.py

flash/data/auto_dataset.py

flash/data/callback.py

edgarriba · 2021-04-06T13:18:11Z

flash/data/data_module.py

-            _ = next(iter(self.predict_dataloader()))
-
-    def visualize(self, batch: Dict[str, Any], stage: RunningStage) -> None:
+    def show(self, batch: Dict[str, Any], stage: RunningStage) -> None:


just to leave here as a comment what I suggested in the call: This method and all the other methods callings that one just collect or fetch a batch. I would suggest later to rename to fetch. Visualization is just one use case once you have cached the data. A general purpose thing could be profiling or data inspection.

Let's change in another PR with team approval.

flash/data/process.py

tests/data/test_auto_dataset.py

edgarriba

LGTM

flash/data/base_viz.py

…tning-flash into base_viz_2

tchaton added 9 commits March 30, 2021 18:30

wip

168b231

add base_viz + new features for DataPipeline

cda64d3

update

2b2c499

resolve flake8

6db6b1c

update

f61deea

Merge branch 'master' into base_viz

cb85981

resolve tests

ffaa7c7

update

596a523

wip

2fdefbe

tchaton requested review from Borda, carmocca, justusschock, kaushikb11 and teddykoker as code owners March 31, 2021 17:35

tchaton self-assigned this Mar 31, 2021

tchaton added this to the 0.2 milestone Mar 31, 2021

tchaton changed the base branch from master to data_pipeline_current_fn March 31, 2021 17:35

tchaton changed the title ~~[feat] Add BaseViz Callback (2 / 2)~~ [WIP] Add BaseViz Callback (2 / 2) [Don't merge] Mar 31, 2021

tchaton changed the base branch from data_pipeline_current_fn to master March 31, 2021 17:36

update

4381441

tchaton changed the base branch from master to data_pipeline_current_fn March 31, 2021 18:04

tchaton changed the base branch from data_pipeline_current_fn to master March 31, 2021 18:05

tchaton added 7 commits March 31, 2021 19:07

resolve doc

d572248

resolve doc

b928fc5

update doc

9381d41

update

108a7cc

update

6da92b3

update

d4cf9f5

convert to staticmethod

16deb7b

resolve bug

84eaa68

tchaton changed the base branch from master to data_pipeline_current_fn April 1, 2021 10:49

tchaton added 2 commits April 1, 2021 11:51

Merge branch 'data_pipeline_current_fn' into base_viz_2

881851a

update

fb25c04

Base automatically changed from data_pipeline_current_fn to master April 1, 2021 11:33

tchaton changed the base branch from master to base_viz April 1, 2021 11:33

tchaton changed the base branch from base_viz to master April 1, 2021 11:33

tchaton added 4 commits April 1, 2021 12:35

Merge branch 'master' into base_viz_2

cc760a5

update

d3932c9

Merge branch 'base_viz_2' of https://github.com/PyTorchLightning/ligh…

ee9f781

…tning-flash into base_viz_2

add test

f6f33b8

edgarriba approved these changes Apr 1, 2021

View reviewed changes

tchaton added 5 commits April 1, 2021 16:35

update

2de0e15

resolve tests

631f06f

resolve flake8

bda5ff2

update

0e74167

update

d0fb78d

carmocca reviewed Apr 6, 2021

View reviewed changes

edgarriba approved these changes Apr 6, 2021

View reviewed changes

Borda changed the title ~~[WIP] Add BaseViz Callback (2 / 2) [Don't merge]~~ [WIP] Add BaseViz Callback (2 / 2) Apr 6, 2021

Borda marked this pull request as draft April 6, 2021 13:51

tchaton added 2 commits April 6, 2021 15:58

update

098d7ab

Merge branch 'master' into base_viz_2

ba0a992

tchaton marked this pull request as ready for review April 6, 2021 15:01

edgarriba approved these changes Apr 6, 2021

View reviewed changes

flash/data/base_viz.py Show resolved Hide resolved

tchaton added 2 commits April 6, 2021 19:23

resolve test

9bdd179

Merge branch 'base_viz_2' of https://github.com/PyTorchLightning/ligh…

67ba94c

…tning-flash into base_viz_2

tchaton changed the title ~~[WIP] Add BaseViz Callback (2 / 2)~~ Add BaseViz Callback (2 / 2) Apr 6, 2021

tchaton merged commit 6a4948a into master Apr 6, 2021

tchaton deleted the base_viz_2 branch April 6, 2021 20:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add BaseViz Callback (2 / 2) #201

Add BaseViz Callback (2 / 2) #201

tchaton commented Mar 31, 2021 •

edited

Loading

codecov bot commented Mar 31, 2021 •

edited

Loading

carmocca Apr 6, 2021

tchaton Apr 6, 2021

edgarriba left a comment

edgarriba Apr 6, 2021

tchaton Apr 6, 2021

edgarriba left a comment

		"""Called after `per_batch_transform_on_device` """


		class ControlFlow(FlashCallback):

Add BaseViz Callback (2 / 2) #201

Add BaseViz Callback (2 / 2) #201

Conversation

tchaton commented Mar 31, 2021 • edited Loading

What does this PR do?

Before submitting

PR review

Did you have fun?

codecov bot commented Mar 31, 2021 • edited Loading

Codecov Report

carmocca Apr 6, 2021

Choose a reason for hiding this comment

tchaton Apr 6, 2021

Choose a reason for hiding this comment

edgarriba left a comment

Choose a reason for hiding this comment

edgarriba Apr 6, 2021

Choose a reason for hiding this comment

tchaton Apr 6, 2021

Choose a reason for hiding this comment

edgarriba left a comment

Choose a reason for hiding this comment

tchaton commented Mar 31, 2021 •

edited

Loading

codecov bot commented Mar 31, 2021 •

edited

Loading