Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix vgg backbone num_features #154

Merged
merged 2 commits into from
Mar 3, 2021
Merged

Conversation

kaushikb11
Copy link
Contributor

What does this PR do?

Fixes vgg backbone num_features

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #154 (7cf48bc) into master (c505c58) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #154   +/-   ##
=======================================
  Coverage   87.39%   87.39%           
=======================================
  Files          49       49           
  Lines        1579     1579           
=======================================
  Hits         1380     1380           
  Misses        199      199           
Flag Coverage Δ
unittests 87.39% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/vision/backbones.py 93.54% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 557cd8d...b7def68. Read the comment docs.

@Borda Borda enabled auto-merge (squash) March 3, 2021 14:20
@Borda Borda disabled auto-merge March 3, 2021 14:22
@Borda Borda merged commit 1b056c7 into Lightning-Universe:master Mar 3, 2021
@kaushikb11 kaushikb11 deleted the fix/vgg branch March 3, 2021 14:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working Ready to Go
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants