Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add serve support for object detection #1370

Merged
merged 6 commits into from
Jun 30, 2022

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Jun 30, 2022

What does this PR do?

Fixes #1279

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ethanwharris ethanwharris added the enhancement New feature or request label Jun 30, 2022
@ethanwharris ethanwharris added this to the 0.8.0 milestone Jun 30, 2022
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #1370 (40dbcb3) into master (323a044) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1370   +/-   ##
=======================================
  Coverage   92.77%   92.77%           
=======================================
  Files         285      285           
  Lines       12671    12685   +14     
=======================================
+ Hits        11755    11768   +13     
- Misses        916      917    +1     
Flag Coverage Δ
unittests 92.77% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/integrations/icevision/transforms.py 92.30% <100.00%> (+0.23%) ⬆️
flash/core/utilities/imports.py 91.42% <100.00%> (ø)
flash/image/detection/model.py 97.29% <100.00%> (+0.86%) ⬆️
flash/image/instance_segmentation/data.py 100.00% <100.00%> (ø)
flash/image/keypoint_detection/data.py 97.72% <100.00%> (ø)
flash/core/serve/dag/task.py 96.82% <0.00%> (-1.06%) ⬇️
flash/text/question_answering/model.py 93.87% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 323a044...40dbcb3. Read the comment docs.

@ethanwharris ethanwharris merged commit d751b83 into master Jun 30, 2022
@ethanwharris ethanwharris deleted the feature/object_detection_serve branch June 30, 2022 13:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flash serve on Object Detection task
2 participants