This repository was archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 210
Fix support for plain LightningModules with FlashDataModule #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krshrimali
commented
Apr 8, 2022
@ethanwharris - Regarding the doc update, can you help link the file/section that should be revised that it's now supported? |
Codecov Report
@@ Coverage Diff @@
## master #1281 +/- ##
=======================================
Coverage 91.79% 91.80%
=======================================
Files 285 285
Lines 12793 12793
=======================================
+ Hits 11743 11744 +1
+ Misses 1050 1049 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Borda
approved these changes
Apr 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ethanwharris
approved these changes
Apr 14, 2022
krshrimali
added a commit
that referenced
this pull request
Apr 27, 2022
Co-authored-by: Ethan Harris <[email protected]>
krshrimali
added a commit
that referenced
this pull request
Apr 27, 2022
ethanwharris
added a commit
that referenced
this pull request
Apr 27, 2022
Co-authored-by: Ethan Harris <[email protected]>
ethanwharris
pushed a commit
that referenced
this pull request
Apr 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before this PR, there would be an error of missing attribute
process_<train/val/test/predict>_dataset
while using a FlashDataModule
with plainLightningModule
.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃