Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

Fix support for plain LightningModules with FlashDataModule #1281

Merged
merged 3 commits into from
Apr 14, 2022

Conversation

krshrimali
Copy link
Contributor

@krshrimali krshrimali commented Apr 8, 2022

What does this PR do?

Before this PR, there would be an error of missing attribute process_<train/val/test/predict>_dataset while using a Flash DataModule with plain LightningModule.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@krshrimali
Copy link
Contributor Author

@ethanwharris - Regarding the doc update, can you help link the file/section that should be revised that it's now supported?

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #1281 (2c3a35d) into master (2b2e4dd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1281   +/-   ##
=======================================
  Coverage   91.79%   91.80%           
=======================================
  Files         285      285           
  Lines       12793    12793           
=======================================
+ Hits        11743    11744    +1     
+ Misses       1050     1049    -1     
Flag Coverage Δ
unittests 91.80% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/data/data_module.py 94.52% <100.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b2e4dd...2c3a35d. Read the comment docs.

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ethanwharris ethanwharris added the bug / fix Something isn't working label Apr 11, 2022
@ethanwharris ethanwharris added this to the 0.7.x milestone Apr 11, 2022
@ethanwharris ethanwharris enabled auto-merge (squash) April 14, 2022 19:55
@ethanwharris ethanwharris merged commit daf2a05 into master Apr 14, 2022
@ethanwharris ethanwharris deleted the fix/plain_lm_support branch April 14, 2022 21:12
krshrimali added a commit that referenced this pull request Apr 27, 2022
ethanwharris added a commit that referenced this pull request Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants