Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix support for torch 11 #1234

Merged
merged 3 commits into from
Mar 15, 2022
Merged

Fix support for torch 11 #1234

merged 3 commits into from
Mar 15, 2022

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Mar 15, 2022

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ethanwharris ethanwharris added the bug / fix Something isn't working label Mar 15, 2022
@ethanwharris ethanwharris added this to the 0.7.x milestone Mar 15, 2022
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #1234 (9a6331b) into master (6aebfbe) will increase coverage by 4.54%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #1234      +/-   ##
==========================================
+ Coverage   75.46%   80.00%   +4.54%     
==========================================
  Files         284      284              
  Lines       12755    12754       -1     
==========================================
+ Hits         9625    10204     +579     
+ Misses       3130     2550     -580     
Flag Coverage Δ
unittests 80.00% <33.33%> (+4.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/text/question_answering/input.py 95.12% <0.00%> (+67.07%) ⬆️
flash/text/seq2seq/core/input.py 97.29% <0.00%> (+45.94%) ⬆️
flash/core/serve/types/bbox.py 100.00% <100.00%> (ø)
flash/core/integrations/icevision/transforms.py 18.24% <0.00%> (-75.00%) ⬇️
...lash/image/embedding/vissl/transforms/multicrop.py 27.27% <0.00%> (-69.70%) ⬇️
flash/core/integrations/icevision/data.py 31.91% <0.00%> (-63.83%) ⬇️
flash/image/embedding/heads/vissl_heads.py 36.36% <0.00%> (-63.64%) ⬇️
flash/image/detection/input.py 38.04% <0.00%> (-61.96%) ⬇️
...ash/image/classification/integrations/baal/loop.py 33.08% <0.00%> (-61.77%) ⬇️
flash/image/embedding/losses/vissl_losses.py 39.47% <0.00%> (-60.53%) ⬇️
... and 138 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aebfbe...9a6331b. Read the comment docs.

@ethanwharris ethanwharris changed the title [WIP] Fix support for torch 11 Fix support for torch 11 Mar 15, 2022
@ethanwharris ethanwharris merged commit 1f42c7c into master Mar 15, 2022
@ethanwharris ethanwharris deleted the bugfix/torch_11_support branch March 15, 2022 17:27
ethanwharris added a commit that referenced this pull request Mar 30, 2022
ethanwharris added a commit that referenced this pull request Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant