-
Notifications
You must be signed in to change notification settings - Fork 211
feat: Add Retinanet and backbones for detection #121
feat: Add Retinanet and backbones for detection #121
Conversation
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
==========================================
+ Coverage 87.12% 87.39% +0.26%
==========================================
Files 49 49
Lines 1554 1579 +25
==========================================
+ Hits 1354 1380 +26
+ Misses 200 199 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
fpn: bool = True, | ||
pretrained: bool = True, | ||
pretrained_backbone: bool = True, | ||
trainable_backbone_layers: int = 3, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic could/should
be within FinetuningCallback.
If the user requires model= fasterrcnn
, then it should choose the FasterRCNNFinetuning Callback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both the models will have the same FineTuningCallback
as they would have similar backbones, but different heads. But yes, could think of moving trainable_backbone_layers
for FineTuningCallback
OR we could offer some options for finetuning
functionalities to the User and it would override the trainable_backbone_layers
.
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
What does this PR do?
Add Retinanet & backbones for detection with
fpn
support.Support for
torchvision
andbolts
backbones.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃