This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 212
Add output
argument to Trainer.predict
and remove DataPipelineState
#1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanwharris
added
Data Pipeline V2
enhancement
New feature or request
Refactor (Functional)
labels
Feb 8, 2022
ethanwharris
changed the title
Add
[PoC] Add Feb 9, 2022
output
argument to Trainer.predict
and remove DataPipelineState
output
argument to Trainer.predict
and remove DataPipelineState
ethanwharris
requested review from
ananyahjha93,
Borda,
carmocca,
edenlightning,
justusschock,
kaushikb11 and
tchaton
as code owners
February 9, 2022 19:06
Codecov Report
@@ Coverage Diff @@
## master #1157 +/- ##
==========================================
- Coverage 89.26% 88.96% -0.30%
==========================================
Files 286 285 -1
Lines 13045 12745 -300
==========================================
- Hits 11644 11339 -305
- Misses 1401 1406 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ethanwharris
changed the title
[PoC] Add
Add Feb 9, 2022
output
argument to Trainer.predict
and remove DataPipelineState
output
argument to Trainer.predict
and remove DataPipelineState
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
output
argument toTrainer.predict
collate_fn
andinput_transform
properties to theDatasetProcessor
base classProcessState
(refacors text data to apply tokenization in the collate function instead)DataPipelineState
DataPipeline
With the state gone, there is now no more magic happening in the background. This means that properties such as
labels
andparameters
are required to be passed to the task by the user.Fixes #920
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃