Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

Add FlashRegistry of Available Heads for flash.image.ImageClassifier #1152

Conversation

ajndkr
Copy link
Contributor

@ajndkr ajndkr commented Feb 2, 2022

What does this PR do?

This PR adds a FlashRegistry to flash.image.ImageClassifier.

Fixes #1150

Changelog

Added:

  • ✨ added IMAGE_CLASSIFIER_HEADS flash registry for flash.image.ImageClassifier
  • ✅ added unit test to test new heads registry

Updated:

  • ⚡ updated flash.image.ImageClassifier to use IMAGE_CLASSIFIER_HEADS flash registry

Notes:

  • The scope of implementation is limited to the heads currently available for ImageClassifier.
  • All unit tests have passed locally (with make test)

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AjinkyaIndulkar This looks great! Left a small comment, could you also add a line to CHANGELOG.md?

@ajndkr
Copy link
Contributor Author

ajndkr commented Feb 2, 2022

@AjinkyaIndulkar This looks great! Left a small comment, could you also add a line to CHANGELOG.md?

Sure. I'll add your suggestion as well.

@ajndkr ajndkr requested a review from ethanwharris February 2, 2022 20:07
@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #1152 (3e4b94a) into master (e65020c) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1152      +/-   ##
==========================================
+ Coverage   89.18%   89.24%   +0.05%     
==========================================
  Files         285      286       +1     
  Lines       13008    13022      +14     
==========================================
+ Hits        11601    11621      +20     
+ Misses       1407     1401       -6     
Flag Coverage Δ
unittests 89.24% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/model.py 88.82% <100.00%> (+1.02%) ⬆️
flash/image/classification/heads.py 100.00% <100.00%> (ø)
flash/image/classification/model.py 80.00% <100.00%> (+1.15%) ⬆️
flash/tabular/forecasting/input.py 97.05% <0.00%> (ø)
flash/text/question_answering/model.py 93.28% <0.00%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e65020c...3e4b94a. Read the comment docs.

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM 😃

@ethanwharris ethanwharris added the enhancement New feature or request label Feb 4, 2022
@ethanwharris ethanwharris added this to the v0.7 milestone Feb 4, 2022
@ethanwharris ethanwharris merged commit 2ca83bc into Lightning-Universe:master Feb 4, 2022
@ajndkr ajndkr deleted the feature/1150-add-classifier-head-registry branch February 4, 2022 19:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create FlashRegistry of Available Heads for flash.image.ImageClassifier
2 participants