Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Docstrings for SpeechRecognitionData #1097

Merged
merged 7 commits into from
Jan 5, 2022

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Jan 5, 2022

What does this PR do?

Part of #957

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #1097 (b9077cc) into master (a040936) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1097      +/-   ##
==========================================
+ Coverage   88.01%   88.13%   +0.12%     
==========================================
  Files         281      281              
  Lines       12807    12819      +12     
==========================================
+ Hits        11272    11298      +26     
+ Misses       1535     1521      -14     
Flag Coverage Δ
unittests 88.13% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/audio/speech_recognition/cli.py 100.00% <ø> (ø)
flash/audio/speech_recognition/data.py 100.00% <100.00%> (+13.33%) ⬆️
flash/audio/speech_recognition/input.py 98.78% <100.00%> (+12.53%) ⬆️
flash/core/data/utilities/samples.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a040936...b9077cc. Read the comment docs.

@ethanwharris ethanwharris added Data Pipeline V2 documentation Improvements or additions to documentation labels Jan 5, 2022
@ethanwharris ethanwharris marked this pull request as ready for review January 5, 2022 17:09
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful work!

@ethanwharris ethanwharris merged commit b931fc1 into master Jan 5, 2022
@ethanwharris ethanwharris deleted the docs/speech_recognition_data branch January 5, 2022 20:51
@ethanwharris ethanwharris mentioned this pull request Jan 5, 2022
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Data Pipeline V2 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants