Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Data Pipeline V2: Rename all Output implementations to end in Output #1011

Merged
merged 18 commits into from
Nov 30, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 30, 2021

What does this PR do?

Fixes #937

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #1011 (d3d750e) into master (b8085f0) will decrease coverage by 8.31%.
The diff coverage is 96.96%.

❗ Current head d3d750e differs from pull request most recent head 779b646. Consider uploading reports for the commit 779b646 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1011      +/-   ##
==========================================
- Coverage   82.37%   74.06%   -8.32%     
==========================================
  Files         254      254              
  Lines       13498    13506       +8     
==========================================
- Hits        11119    10003    -1116     
- Misses       2379     3503    +1124     
Flag Coverage Δ
unittests 74.06% <96.96%> (-8.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/detection/output.py 30.00% <50.00%> (ø)
flash/core/classification.py 62.57% <100.00%> (+1.93%) ⬆️
flash/core/data/output.py 83.33% <100.00%> (ø)
flash/image/classification/model.py 70.45% <100.00%> (ø)
flash/image/detection/model.py 68.18% <100.00%> (ø)
flash/image/face_detection/model.py 37.17% <100.00%> (ø)
flash/image/instance_segmentation/model.py 63.33% <100.00%> (ø)
flash/image/keypoint_detection/model.py 68.18% <100.00%> (ø)
flash/image/segmentation/data.py 79.12% <100.00%> (-1.95%) ⬇️
flash/image/segmentation/model.py 91.89% <100.00%> (ø)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8085f0...779b646. Read the comment docs.

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some classes are missing from here: https://github.com/PyTorchLightning/lightning-flash/blob/master/flash/core/classification.py

e.g. Labels should become either LabelsOutput or LabelsClassificationOutput

Mind renaming those ones too?

flash/core/classification.py Outdated Show resolved Hide resolved
flash/core/classification.py Outdated Show resolved Hide resolved
flash/core/classification.py Outdated Show resolved Hide resolved
flash/core/classification.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM 😃

@ethanwharris ethanwharris merged commit 54fe693 into master Nov 30, 2021
@ethanwharris ethanwharris deleted the issue_937_rename_all_outputs branch November 30, 2021 21:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename all Output implementations to end in Output
2 participants