-
Notifications
You must be signed in to change notification settings - Fork 212
Data Pipeline V2: Rename all Output implementations to end in Output #1011
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1011 +/- ##
==========================================
- Coverage 82.37% 74.06% -8.32%
==========================================
Files 254 254
Lines 13498 13506 +8
==========================================
- Hits 11119 10003 -1116
- Misses 2379 3503 +1124
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some classes are missing from here: https://github.com/PyTorchLightning/lightning-flash/blob/master/flash/core/classification.py
e.g. Labels
should become either LabelsOutput
or LabelsClassificationOutput
Mind renaming those ones too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, LGTM 😃
What does this PR do?
Fixes #937
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃