Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

DataPipeline Refactor V2: Simplify Input Transform #1010

Merged
merged 15 commits into from
Dec 1, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 30, 2021

What does this PR do?

Fixes #924

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton self-assigned this Nov 30, 2021
@tchaton tchaton added this to the v0.6 milestone Nov 30, 2021
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #1010 (9c3d408) into master (43cfb3d) will decrease coverage by 0.04%.
The diff coverage is 92.30%.

❗ Current head 9c3d408 differs from pull request most recent head 1eeae27. Consider uploading reports for the commit 1eeae27 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1010      +/-   ##
==========================================
- Coverage   88.29%   88.25%   -0.05%     
==========================================
  Files         254      254              
  Lines       13506    13422      -84     
==========================================
- Hits        11925    11845      -80     
+ Misses       1581     1577       -4     
Flag Coverage Δ
unittests 88.25% <92.30%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/audio/classification/transforms.py 86.36% <0.00%> (-0.60%) ⬇️
flash/core/data/data_module.py 95.42% <ø> (ø)
flash/core/data/io/input.py 69.70% <ø> (ø)
flash/core/integrations/icevision/transforms.py 90.27% <ø> (ø)
flash/image/face_detection/data.py 51.56% <ø> (ø)
flash/image/segmentation/transforms.py 100.00% <ø> (ø)
flash/text/classification/data.py 96.90% <ø> (ø)
flash/text/question_answering/data.py 87.02% <ø> (ø)
flash/image/classification/transforms.py 93.75% <60.00%> (ø)
flash/core/data/base_viz.py 100.00% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43cfb3d...1eeae27. Read the comment docs.

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comment

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Ethan Harris <[email protected]>
@ethanwharris ethanwharris merged commit bf67d16 into master Dec 1, 2021
@ethanwharris ethanwharris deleted the issue_924_simplify_input_transform branch December 1, 2021 11:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify InputTransform hooks
2 participants