Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Slurm 24.11.x #354

Closed
tazend opened this issue Dec 5, 2024 · 3 comments · Fixed by #361
Closed

Support for Slurm 24.11.x #354

tazend opened this issue Dec 5, 2024 · 3 comments · Fixed by #361
Assignees
@tazend

Comments

@tazend
Copy link
Member

tazend commented Dec 5, 2024

Already working on it
@tazend tazend self-assigned this Dec 12, 2024
@tazend tazend mentioned this issue Dec 30, 2024
Merged
@tazend
Copy link
Member Author

tazend commented Dec 30, 2024

support for 24.11.x added with #361

@walterdejong
Copy link

Tested this from your fork just this morning, nice work.

One remark, pyslurm.version() was removed. We can live with pyslurm.__version__, that's okay.

@tazend
Copy link
Member Author

tazend commented Dec 30, 2024 •
edited
Loading

Hi @walterdejong,

thanks for the feedback.
Yeah I removed pyslurm.version() because it seemed rendundant since one can rely on __version__ directly. Perhaps it is a bit uglier now though, apoligies for that - maybe it was not the most necessary change anyway :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tazend tazend

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support for Slurm 24.11.x tazend/pyslurm
2 participants
@walterdejong @tazend