Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more typos in Job_dict, QOS_info #251

Closed
schluenz opened this issue Dec 21, 2022 · 1 comment · Fixed by #252
Closed

more typos in Job_dict, QOS_info #251

schluenz opened this issue Dec 21, 2022 · 1 comment · Fixed by #252

Comments

@schluenz
Copy link
Contributor

Hi,

similar to #241 and #243 there are few more places where (supposedly) typos have been introduced (we stumbled across max_jobs_pu):

diff --git a/pyslurm/pyslurm.pyx b/pyslurm/pyslurm.pyx
index 7846558..bea119e 100644
--- a/pyslurm/pyslurm.pyx
+++ b/pyslurm/pyslurm.pyx
@@ -2065,12 +2065,12 @@ cdef class job:
             if self._record.pn_min_memory & slurm.MEM_PER_CPU:
                 self._record.pn_min_memory &= (~slurm.MEM_PER_CPU)
                 Job_dict['mem_per_cpu'] = True
-                Job_dict['min_memory_cp'] = self._record.pn_min_memory
+                Job_dict['min_memory_cpu'] = self._record.pn_min_memory
                 Job_dict['mem_per_node'] = False
                 Job_dict['min_memory_node'] = None
             else:
                 Job_dict['mem_per_cpu'] = False
-                Job_dict['min_memory_cp'] = None
+                Job_dict['min_memory_cpu'] = None
                 Job_dict['mem_per_node'] = True
                 Job_dict['min_memory_node'] = self._record.pn_min_memory
 
@@ -5106,17 +5106,17 @@ cdef class qos:
                     QOS_info['grp_tres_run_mins'] = slurm.stringOrNone(qos.grp_tres_run_mins, '')
                     # QOS_info['grp_tres_run_mins_ctld']
                     QOS_info['grp_wall'] = qos.grp_wall
-                    QOS_info['max_jobs_p'] = qos.max_jobs_pu
-                    QOS_info['max_submit_jobs_p'] = qos.max_submit_jobs_pu
+                    QOS_info['max_jobs_pu'] = qos.max_jobs_pu
+                    QOS_info['max_submit_jobs_pu'] = qos.max_submit_jobs_pu
                     QOS_info['max_tres_mins_pj'] = slurm.stringOrNone(qos.max_tres_mins_pj, '')
                     # QOS_info['max_tres_min_pj_ctld']
                     QOS_info['max_tres_pj'] = slurm.stringOrNone(qos.max_tres_pj, '')
                     # QOS_info['max_tres_min_pj_ctld']
                     QOS_info['max_tres_pn'] = slurm.stringOrNone(qos.max_tres_pn, '')
                     # QOS_info['max_tres_min_pn_ctld']
-                    QOS_info['max_tres_p'] = slurm.stringOrNone(qos.max_tres_pu, '')
+                    QOS_info['max_tres_pu'] = slurm.stringOrNone(qos.max_tres_pu, '')
                     # QOS_info['max_tres_min_pu_ctld']
-                    QOS_info['max_tres_run_mins_p'] = slurm.stringOrNone(
+                    QOS_info['max_tres_run_mins_pu'] = slurm.stringOrNone(
                         qos.max_tres_run_mins_pu, '')
 
                     QOS_info['max_wall_pj'] = qos.max_wall_pj
@tazend
Copy link
Member

tazend commented Dec 22, 2022

Hi @schluenz

could you create a pull request with those changes?

@schluenz schluenz mentioned this issue Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants