fix: pass RUSTFLAGS#462
Closed
n-bes wants to merge 2 commits into
Closed
Conversation
Author
|
Oh, it is already copied... So, something another is wrong. setuptools-rust/setuptools_rust/build.py Line 625 in f42ae5b |
davidhewitt
reviewed
Sep 6, 2024
davidhewitt
left a comment
davidhewitt
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR. I'm not sure I understand the motivation for the patch, nor what the functional change is from the patch submitted. Could you please elaborate?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom
RUSTFLAGSpassed only when internalRUSTFLAGSis set, fixed it. Possibly fix pypa/pip#12935