Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isort drops noqa comments when on multiple import lines #1721

Closed
levsa opened this issue May 4, 2021 · 1 comment
Closed

isort drops noqa comments when on multiple import lines #1721

levsa opened this issue May 4, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@levsa
Copy link

levsa commented May 4, 2021

pyproject.toml

[tool.isort]
profile = "black"
force_single_line = true

main.py

from some_very_long_filename_to_import_from_that_causes_a_too_long_import_row import (  # noqa: E501
    CONSTANT_1,
)
from some_very_long_filename_to_import_from_that_causes_a_too_long_import_row import (  # noqa: E501
    CONSTANT_2,
)

Running isort main.py drops # noqa: E501 on the second import line. Same bug without "black" profile.

With isort 5.8.0

@timothycrosley timothycrosley added the bug Something isn't working label May 7, 2021
@timothycrosley
Copy link
Member

Thanks for reporting this issue! I'm sorry this affected you! it is now fixed in develop and will be pushed to PyPI in the next release of isort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants