Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend_skip option to skip files *in addition to* files skipped in skip #1684

Closed
Jackenmen opened this issue Mar 6, 2021 · 4 comments
Closed
Labels
enhancement New feature or request

Comments

@Jackenmen
Copy link

This option would behave like skip, but it would add the files specified in extend_skip on top of the ones skipped by skip. I'm guessing that this would most commonly be useful to not have to include the defaults in skip option in isort configuration file when you just want to skip some path in addition to the (imo) useful defaults.
In some environments, it could probably also be useful to pass --extend-skip cli flag to add onto skip that's already included in the isort configuration file. I guess that one would be a bit limited considering that one would probably often already use extend_skip in the configuration and the cli flag would override that, but I'm guessing that at least some would probably be able to work with that anyway.

Here are some tools that already allow this in case that helps :)
flake8
black

@Jackenmen
Copy link
Author

Update: I guess the existing skip_glob might already be enough for this considering it already extends skip. I don't think I'm gonna need this in such case then and I leave it up to you whether this should be closed or not.

@timothycrosley timothycrosley added the enhancement New feature or request label Mar 14, 2021
@timothycrosley
Copy link
Member

Hi @jack1142,

Thanks for bringing this up! I think it makes sense for isort to have an extend skip to stay as CLI compatible with other tools as possible. I've added both an extend skip and extend skip glob flag to address this.

Thanks!

~Timothy

@govindrai
Copy link

Could you guys explain extend_skip? Even after reading the docs I don't understand what it's purpose is

@m000
Copy link

m000 commented Jan 18, 2024

Could you guys explain extend_skip? Even after reading the docs I don't understand what it's purpose is

What's so mysterious about it?

This option would behave like skip, but it would add the files specified in extend_skip on top of the ones skipped by skip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants