Skip to content

Commit 33448c8

Browse files
authored
Renamed assembly name to original assembly name. (#29)
- Going to .NETStandard, the build process was using a different Assembly name. So this is now going back to the original one. - Make sure the correct configuration is used during CI packing. - Renamed ReleaseNotes.md to ChangeLog.md.
1 parent e27da25 commit 33448c8

File tree

7 files changed

+33
-45
lines changed

7 files changed

+33
-45
lines changed

ChangeLog.md

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
# Change Log
2+
All notable changes to this project will be documented in this file.
3+
4+
The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).
5+
6+
7+
## [6.1.0] - 2017-06-07
8+
### Fixed
9+
- The new .NET Standard packaging (in AppVeyor) was creating an incorrect Assembly name. :blush:
10+
11+
## [6.0.0] - 2017-05-27
12+
### Changed
13+
- Supports .NET Standard 1.4! Woot!
14+
15+
### Fixed
16+
- #27: Uri fails to compare/equals when Uri contains characters that get encoded.
17+
18+
## [5.1.0] - 2017-02-06
19+
### Added
20+
- Support for `Headers` in `HttpMessageOptions`.
21+
22+
23+
## [1.0.0 -> 5.0.0] - 2014-08-07 -> 2017-02-06
24+
### Added
25+
- Inital and subsequent releases in supporting faking an `HttpClient` request/response.

ReleaseNotes.md

Lines changed: 0 additions & 9 deletions
This file was deleted.

appveyor.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ build_script:
3535

3636
test_script:
3737
- dotnet test %tests_project_file% -c %CONFIGURATION% -v normal --no-build
38-
- dotnet pack %library_project_file% /p:Version=%APPVEYOR_BUILD_VERSION% --no-build
38+
- dotnet pack %library_project_file% -c %CONFIGURATION% /p:Version=%APPVEYOR_BUILD_VERSION% --no-build
3939

4040
artifacts:
4141
- path: '**\*.nupkg'

src/HttpClient.Helpers/FakeMessageHandler.cs

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,7 @@ public FakeHttpMessageHandler(IEnumerable<HttpMessageOptions> lotsOfOptions)
3939
/// <param name="exception">The exception that will occur.</param>
4040
public FakeHttpMessageHandler(HttpRequestException exception)
4141
{
42-
if (exception == null)
43-
{
44-
throw new ArgumentNullException(nameof(exception));
45-
}
46-
47-
_exception = exception;
42+
_exception = exception ?? throw new ArgumentNullException(nameof(exception));
4843
}
4944

5045
protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage request,

src/HttpClient.Helpers/HttpClient.Helpers.csproj

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
<PackageIconUrl>http://i.imgur.com/bR4Yf.jpg</PackageIconUrl>
1616
<RepositoryUrl>https://github.com/PureKrome/HttpClient.Helpers</RepositoryUrl>
1717
<PackageTags>httpclient worlddomination worldomination unicorn magicalunicorn magical-unicorn</PackageTags>
18+
<RootNamespace>WorldDomination.Net.Http</RootNamespace>
19+
<AssemblyName>WorldDomination.HttpClient.Helpers</AssemblyName>
1820
</PropertyGroup>
1921

2022
<ItemGroup>

src/HttpClient.Helpers/HttpClient.Helpers.nuspec

Lines changed: 0 additions & 26 deletions
This file was deleted.

src/HttpClient.Helpers/HttpMessageOptions.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ namespace WorldDomination.Net.Http
88
{
99
public class HttpMessageOptions
1010
{
11-
private const string _anyValue = "*";
11+
private const string AnyValue = "*";
1212
private HttpContent _httpContent;
1313
private string _httpContentSerialized;
1414

@@ -32,7 +32,7 @@ public class HttpMessageOptions
3232
/// </summary>
3333
public HttpContent HttpContent
3434
{
35-
get { return _httpContent; }
35+
get => _httpContent;
3636
set
3737
{
3838
_httpContent = value;
@@ -50,11 +50,12 @@ public HttpContent HttpContent
5050
// Note: I'm using reflection to set the value in here because I want this value to be _read-only_.
5151
// Secondly, this occurs during a UNIT TEST, so I consider the expensive reflection costs to be
5252
// acceptable in this situation.
53+
// ReSharper disable once UnusedAutoPropertyAccessor.Local
5354
public int NumberOfTimesCalled { get; private set; }
5455

5556
public override string ToString()
5657
{
57-
var httpMethodText = HttpMethod?.ToString() ?? _anyValue;
58+
var httpMethodText = HttpMethod?.ToString() ?? AnyValue;
5859

5960
var headers = Headers != null &&
6061
Headers.Any()

0 commit comments

Comments
 (0)