Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping of smooth_stone_slab to stone_slab (avoiding cobblestone replacements) #3

Open
zeronerve opened this issue Feb 2, 2020 · 4 comments

Comments

@zeronerve
Copy link

Scenario: Any blocks that were placed using older clients as stone_slab (id 44) in older servers (less than 1.12 I think) are being converted to smooth_stone_slab when the worlds are imported into newer servers. This creates a scenario where---because there's no "smooth_stone_slab" in early clients---Protocol Support renders the stone_slab (44) as a cobblestone_slab (44:3), which for us, has disrupted the feel of several maps which rely on smooth_stone_slab. Is it possible that you modify Protocol Support so that older clients interpret any smooth_stone_slab as stone_slab instead of cobblestone_slab, so they'll appear correctly for players using older clients.

This could also correct issue ProtocolSupport/ProtocolSupport#1176

@zeronerve
Copy link
Author

slab-issue

@zeronerve zeronerve changed the title Mapping of Mapping of smooth_stone_slab to stone_slab (avoiding cobblestone replacements) Feb 2, 2020
@Shevchik
Copy link
Member

Shevchik commented Feb 2, 2020

You can configure the mapping yourself using a plugin that uses protocolsupport api, such as protocolsupportstuff. Changing default mappings is always a low priority task for us, so unless somebody PRs changes to ProtocolSupportResourcesGenerator, this change won't be done.

@zeronerve
Copy link
Author

Thanks for the quick reply!

@zeronerve
Copy link
Author

zeronerve commented Feb 2, 2020

I added this to the ProtocolSupportStuff config and everything looks great, thanks!. ....

blocks:
- from-state: minecraft:smooth_stone_slab[type=top]
  to-state: minecraft:stone_slab[type=top]
  before: MINECRAFT_1_12_2
- from-state: minecraft:smooth_stone_slab[type=bottom]
  to-state: minecraft:stone_slab[type=bottom]
  before: MINECRAFT_1_12_2
- from-state: minecraft:smooth_stone_slab[type=double]
  to-state: minecraft:stone_slab[type=double]
  before: MINECRAFT_1_12_2

No more cobblestone slabs.

@Shevchik Shevchik transferred this issue from ProtocolSupport/ProtocolSupport Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants