Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APC may be ignoring encoding issues #86

Open
rdohms opened this issue Feb 21, 2022 · 0 comments
Open

APC may be ignoring encoding issues #86

rdohms opened this issue Feb 21, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@rdohms
Copy link
Member

rdohms commented Feb 21, 2022

As per pack manual page

8.0.0 | This function no longer returns false on failure.

We seem to rely on a !== false check

It now throws ValueError Exceptions which we are not catching.
As per this commit in core.
@rdohms rdohms added the bug Something isn't working label Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rdohms