Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test suite broken with @material-ui/icons-4.11.2 #3366

Closed
mejackreed opened this issue Dec 5, 2020 · 2 comments
Closed

Test suite broken with @material-ui/icons-4.11.2 #3366

mejackreed opened this issue Dec 5, 2020 · 2 comments

Comments

@mejackreed
Copy link
Collaborator

Just raising this as an issue so others are aware.

A recent version of @material-ui/icons-4.11.2 removed displayName from the icons causing some failures in our test suite.

Tracking upstream issue here: mui/material-ui#23831

All icons now in enzyme render as <Memo([object Object]) /> which is not really helpful. There is a proposed solution upstream but I haven't been able to get this to work yet.
@mejackreed mejackreed mentioned this issue Dec 5, 2020
Closed
2 tasks
@mejackreed
Copy link
Collaborator Author

Underlying issue is in mui/material-ui#21134 where displayName is not set on the exterior React.memo

@mejackreed mejackreed mentioned this issue Dec 5, 2020
Merged
@mejackreed
Copy link
Collaborator Author

And an upstream fix in enzyme we can wait on: enzymejs/enzyme#2482

@cbeer cbeer closed this as completed Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cbeer @mejackreed