-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance details of search results panel #2683
Comments
Picking off |
Picking off |
I guess I'll take |
I'll snag the |
@ggeisler which In the example manifest given, that's not the label that is provided (however I'm not seeing that level of label described in the spec). I just want to make sure I'm doing this for the correct label before going down a rabbit hole. (or is this one of those things that can exist anywhere and we just need to deal w/ that?) |
@jkeck Maybe I'm incorrect in suggesting the and assumed that since a In other words, in https://exist.scta.info/exist/apps/scta-app/iiif2/lon/search?q=contradictio that search service response comes in the form of But perhaps that is not a valid assumption? |
Okay, as long as I know specifically that we're talking about the resource label, I can add that. Just wanted to make sure I was doing the right thing and got confused by the other references to label specifically in the content search spec. |
👍 Yeah, I probably should've been more clear about that. |
After the work to display basic content search results has been done via #2670 has been completed, here are some additional details.
Assuming the case where the search service returns a list of complete list of
hits
(e.g. https://contentsearch.stanford.edu) and not paged results:(For reference, I used these results for the mockups, although note that sometimes I adjusted the result text displayed for space reasons, so things don't always map precisely.)
Note A: Hit navigation
chevronLeftSharp
andchevronRightSharp
icons, withpadding: 12px;
for next and previous hit navigation.x of y
, where x = currently selected result item and y = total number of result items/hits.Note B: Hit counter (#2699)
headline 6
typography for the number.radius: 50%;
might do it. If not, try something like16px
.#bdbdbd
or Gray400 for the background color of the counter.Note C: Canvas label (#2702)
headline 6
typography used for the hit counter number.Note D: Hit content
I assume this is done in #2670, with the truncation aspect handled in #2671.
Example: Two hits on same page
This is the same document used in the mockup at the start of this ticket, but here the user has navigated to result item #3. Note that the background color of the result item hit counter for result item #4 is blue, because it is present on the currently display canvas.
If the user was to navigate to the fourth result item, its hit counter background color, and hit highlighting on the canvas, would change to yellow, while those elements of result item #3 would change to blue.
If result item label is provided
If the search service returns a
label
associated with each result item (see https://exist.scta.info/exist/apps/scta-app/iiif2/lon/search?q=contradictio for an example), the label values should be added to the panel content described above.label
value as a new line just above the result item content (highlighted in the mockup below), assubtitle 2
typography.The text was updated successfully, but these errors were encountered: