Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give consumers the ability to apply a custom retry strategy for HTTP calls #106

Open
mikejancar opened this issue Feb 17, 2022 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mikejancar
Copy link
Member

🚀 Feature request

Please describe what is needed

The retry strategy for failed HTTP calls in the HttpApiService is currently hardcoded to:

  • a maximum of 3 attempts
  • a retry wait period of 1000 ms
  • ignore HTTP status codes of 0

We should give our consumers the ability to provide a custom strategy.

Describe the solution you'd like

The simplest way to achieve this would be to allow a custom configuration via the AppConfiguration object.

Describe alternatives you've considered

N/A

Additional context

https://github.com/Progressive/oculr-ngx/blob/a6a98dc8f52c1430f9294e554d990e62231aae84/projects/oculr-ngx/src/lib/destinations/http-api/http-api.service.ts#L71

@mikejancar mikejancar added enhancement New feature or request help wanted Extra attention is needed labels Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant