Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for retry flow in HttpApiService #105

Open
mikejancar opened this issue Feb 17, 2022 · 0 comments
Open

Add unit tests for retry flow in HttpApiService #105

mikejancar opened this issue Feb 17, 2022 · 0 comments
Labels
help wanted Extra attention is needed testing

Comments

@mikejancar
Copy link
Member

🚀 Feature request

Please describe what is needed

Ideally, we would have unit tests that cover the retry functionality in the HttpApiService

Describe the solution you'd like

We were never able to get these to work due to the complexity of having the call fail, wait in the test and then retry. I'm sure this is doable, but it requires a deeper dive in how to attack this use case.

Describe alternatives you've considered

N/A

Additional context

https://github.com/Progressive/oculr-ngx/blob/c15535ade25ab5b8398890fa0411d1b6098c324b/projects/oculr-ngx/src/lib/destinations/http-api/http-api.service.spec.ts#L132

https://github.com/Progressive/oculr-ngx/blob/c15535ade25ab5b8398890fa0411d1b6098c324b/projects/oculr-ngx/src/lib/destinations/http-api/http-api.service.spec.ts#L156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed testing
Projects
None yet
Development

No branches or pull requests

1 participant