Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify PageItemLookup implementations #246

Closed
JeroenDeDauw opened this issue Mar 18, 2025 · 0 comments
Closed

Simplify PageItemLookup implementations #246

JeroenDeDauw opened this issue Mar 18, 2025 · 0 comments
Assignees
@alistair3149
Labels
good first issue Good for newcomers maintainability Code quality, tests, etc

Comments

@JeroenDeDauw
Copy link
Member

We overcomplicated things with the PageItemLookup implementations. We have NullPageItemLookup and SitelinkPageItemLookup constructed via PageItemLookupFactory. These 3 can be combined into one implementation of PageItemLookup without any design downsides and some upsides.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alistair3149 alistair3149

Labels
good first issue Good for newcomers maintainability Code quality, tests, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JeroenDeDauw @alistair3149