Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The raycast was skipping the block that the client is inside. #145

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zardoy
Copy link

@zardoy zardoy commented Oct 20, 2024

That was causing major client misalignment. I don't see a reason why it should be otherwise. There are so many valid cases like being inside the door or bushes.

@rom1504
Copy link
Member

rom1504 commented Oct 20, 2024

https://github.com/PrismarineJS/prismarine-world/blob/master/test/raycast.test.js

Please add a test with such a "bot has head in bush" case

@zardoy
Copy link
Author

zardoy commented Oct 20, 2024

@rom1504 Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs triage
Development

Successfully merging this pull request may close these issues.

2 participants