Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.19 fromString - 'reset' ignored by client #85

Open
dcrime opened this issue Nov 9, 2022 · 0 comments
Open

1.19 fromString - 'reset' ignored by client #85

dcrime opened this issue Nov 9, 2022 · 0 comments

Comments

@dcrime
Copy link

dcrime commented Nov 9, 2022

While testing fromString in 1.19 (vanilla) I noticed the formatting isn't reset
Example string '&cSome &rSample &aText'
Output:

{
    text: 'Some',
    color: 'red',
    extra: [{
        text: 'Sample',
        color: 'reset',
        extra: [{
            text: 'Text',
            color: 'green',
        }]
    }]
}

While this should give (red)Some (white)Sample (green)Text
It gives (red)Some (red)Sample (green)Text

Best solution I can think of is creating a root object and appending to it when reset (Or end of string) is encountered rather than using inheritance for the whole string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant