Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/102 #103

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Issue/102 #103

wants to merge 2 commits into from

Conversation

tabbry
Copy link

@tabbry tabbry commented Nov 2, 2024

As requested in #102 this PR will add some basic tests, which show that in 1.20.5 a shovel is no longer considered to have a lower digTime than the hand. So far it seemed like the digTime didn't depend on the tool used. When inspecting materials.json it can also be observed that there are a lot of 1.0 values.

The code change also shows that this problem was not there in 1.20.4.

@tabbry tabbry mentioned this pull request Nov 2, 2024
@extremeheat
Copy link
Member

I think this type of test would be helpful to have this tested in minecraft-data on PR there. This test here is only going to trigger when someone opens a PR on prismarine-block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants