Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spawning in 1.16.5 worlds, 1.17 #660

Merged
merged 3 commits into from
Jan 1, 2025

Conversation

extremeheat
Copy link
Member

@extremeheat extremeheat commented Dec 31, 2024

  • Fix missing spawn packets causing player to become glitched/world not render
  • Fixes to registry use

@extremeheat extremeheat marked this pull request as ready for review December 31, 2024 22:44
@extremeheat extremeheat changed the title Fix spawning in 1.16.5 worlds Fix spawning in 1.16.5 worlds, 1.17 Jan 1, 2025
src/index.js Show resolved Hide resolved
@rom1504
Copy link
Member

rom1504 commented Jan 1, 2025

I think it could be nicer to first do a PR changing the registry stuff with no change on behavior then another PR doing the 1.17 and 1.16.5 fixes

But I guess I'm also ok to merge like this

So more important question: does it work ?
For example

  • Loading/saving the world
  • Basic features like dig build, move around, commands

@extremeheat
Copy link
Member Author

extremeheat commented Jan 1, 2025

Commands were unchanged 1.16-1.18

Movement, dig, break and world saving are working 1.16 - 1.18 (the mask issue should only have been a problem when sending over network)

I'll open another PR after this one for 1.18, not many changes needed there. For 1.16.5 the main issue seems to have been missing status packets (aside from issues in pchunk/panvil)

@rom1504
Copy link
Member

rom1504 commented Jan 1, 2025

Ok

@rom1504 rom1504 merged commit 414d4dc into PrismarineJS:master Jan 1, 2025
15 checks passed
@rom1504 rom1504 mentioned this pull request Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants