Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible path to follow when fixing chunks. #658

Closed
FabioSmuu opened this issue Nov 23, 2024 · 1 comment
Closed

Possible path to follow when fixing chunks. #658

FabioSmuu opened this issue Nov 23, 2024 · 1 comment

Comments

@FabioSmuu
Copy link

FabioSmuu commented Nov 23, 2024

I made the chunk changes from 1.16.5 to 1.17.1 and then I went straight to debugging.

In my analysis I noticed that when reentering the world, the sectionMask sometimes doesn't have toLongArray.

I did a StackTracer until I found the key and it was indeed in the rendering of the chunk.

The problem occurs when the player leaves and reenters the server (this will be worse if you force the server to shut down.)

So, yes, the problem is related to saving the world and in the chunk.

See my logs:

[OK][Smuu Log] typof sectionMask object
[OK][Smuu Log] typof skyLightMask object
[OK][Smuu Log] typof blockLightMask object
[Smuu Log] TypeError: this.sectionMask.toLongArray is not a function
    at ChunkColumn.getMask (ChunkColumn.js:244:31)
    at world.js:190:33
    at Entity.behavior (behavior.js:24:14)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async player.login (login.js:223:9)
    at async Server.<anonymous> (login.js:29:7) TypeError: this.sectionMask.toLongArray is not a function
    at ChunkColumn.getMask (/home/fabio/Documentos/nodejs/minecraft-flying-squid/flying-squid/node_modules/prismarine-chunk/src/pc/1.17/ChunkColumn.js:244:31)
    at /home/fabio/Documentos/nodejs/minecraft-flying-squid/flying-squid/src/lib/plugins/world.js:190:33
    at Entity.behavior (/home/fabio/Documentos/nodejs/minecraft-flying-squid/flying-squid/src/lib/behavior.js:24:14)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async player.login (/home/fabio/Documentos/nodejs/minecraft-flying-squid/flying-squid/src/lib/plugins/login.js:223:9)
    at async Server.<anonymous> (/home/fabio/Documentos/nodejs/minecraft-flying-squid/flying-squid/src/lib/plugins/login.js:29:7)
[Smuu Log] typof sectionMask number
[Smuu Log] typof skyLightMask number
[Smuu Log] typof blockLightMask object

What I did was just a try/catch after the StackTracer.

@rom1504
Copy link
Member

rom1504 commented Jan 1, 2025

Thanks fixed now

@rom1504 rom1504 closed this as completed Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants