From 5513cd387b66efbdfd9eac205c20899282c0a387 Mon Sep 17 00:00:00 2001 From: hallerite Date: Wed, 1 Jul 2026 23:43:53 +0000 Subject: [PATCH] chore(configs): remove empty *ExperimentalConfig placeholders InferenceExperimentalConfig, OrchestratorExperimentalConfig, RLExperimentalConfig, and SFTExperimentalConfig are all empty (pass) models wired into experimental fields that nothing reads; with extra="forbid" they cannot even hold keys. Co-Authored-By: Claude Fable 5 --- packages/prime-rl-configs/src/prime_rl/configs/inference.py | 6 ------ .../prime-rl-configs/src/prime_rl/configs/orchestrator.py | 6 ------ packages/prime-rl-configs/src/prime_rl/configs/rl.py | 6 ------ packages/prime-rl-configs/src/prime_rl/configs/sft.py | 6 ------ 4 files changed, 24 deletions(-) diff --git a/packages/prime-rl-configs/src/prime_rl/configs/inference.py b/packages/prime-rl-configs/src/prime_rl/configs/inference.py index 80fac520ccb..e66bafe595f 100644 --- a/packages/prime-rl-configs/src/prime_rl/configs/inference.py +++ b/packages/prime-rl-configs/src/prime_rl/configs/inference.py @@ -337,10 +337,6 @@ def validate_replicas_divide_nodes(self): ] -class InferenceExperimentalConfig(BaseConfig): - pass - - class InferenceConfig(BaseConfig): server: ServerConfig = ServerConfig() @@ -436,8 +432,6 @@ class InferenceConfig(BaseConfig): dry_run: bool = False """Only validate and dump resolved configs, then exit early.""" - experimental: InferenceExperimentalConfig = InferenceExperimentalConfig() - @model_validator(mode="after") def validate_multi_node_requires_slurm(self): if self.deployment.type in ("multi_node", "disaggregated") and self.slurm is None: diff --git a/packages/prime-rl-configs/src/prime_rl/configs/orchestrator.py b/packages/prime-rl-configs/src/prime_rl/configs/orchestrator.py index d296178c055..4cff3ea586c 100644 --- a/packages/prime-rl-configs/src/prime_rl/configs/orchestrator.py +++ b/packages/prime-rl-configs/src/prime_rl/configs/orchestrator.py @@ -443,10 +443,6 @@ class NCCLWeightBroadcastConfig(BaseConfig): ] -class OrchestratorExperimentalConfig(BaseConfig): - pass - - class OrchestratorConfig(BaseConfig): algo: AlgoConfig = GRPOAlgoConfig() """Training algorithm: sampling plus the per-token training signal (credit @@ -563,8 +559,6 @@ class OrchestratorConfig(BaseConfig): heartbeat: HeartbeatConfig | None = None """BetterStack heartbeat configuration for monitoring training progress.""" - experimental: OrchestratorExperimentalConfig = OrchestratorExperimentalConfig() - @model_validator(mode="before") @classmethod def _env_to_train(cls, data: Any) -> Any: diff --git a/packages/prime-rl-configs/src/prime_rl/configs/rl.py b/packages/prime-rl-configs/src/prime_rl/configs/rl.py index f7d1179b57a..ad2af7093bd 100644 --- a/packages/prime-rl-configs/src/prime_rl/configs/rl.py +++ b/packages/prime-rl-configs/src/prime_rl/configs/rl.py @@ -46,10 +46,6 @@ ) -class RLExperimentalConfig(BaseConfig): - pass - - class SharedLogConfig(BaseConfig): level: str | None = None """Log level for trainer, orchestrator, and inference. When unset, each sub-config's own log level applies (defaults to ``$PRIME_LOG_LEVEL`` if set, else ``info``).""" @@ -234,8 +230,6 @@ class RLConfig(BaseConfig): dry_run: bool = False """Only validate and dump resolved configs, then exit early.""" - experimental: RLExperimentalConfig = RLExperimentalConfig() - ### Validate configs (e.g. raise for unsupported (combinations of) configs) @model_validator(mode="after") diff --git a/packages/prime-rl-configs/src/prime_rl/configs/sft.py b/packages/prime-rl-configs/src/prime_rl/configs/sft.py index 5a9c6b3eca0..6352bbd8758 100644 --- a/packages/prime-rl-configs/src/prime_rl/configs/sft.py +++ b/packages/prime-rl-configs/src/prime_rl/configs/sft.py @@ -167,10 +167,6 @@ class MultiNodeDeploymentConfig(BaseDeploymentConfig): ] -class SFTExperimentalConfig(BaseConfig): - pass - - class SFTConfig(BaseConfig): model: ModelConfig = ModelConfig() @@ -243,8 +239,6 @@ class SFTConfig(BaseConfig): dry_run: bool = False """Only validate and dump resolved configs, then exit early.""" - experimental: SFTExperimentalConfig = SFTExperimentalConfig() - ### Pre-validation normalization @model_validator(mode="before")