feat(secure): Mark Splatfest sessions as OpenParticipation #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItzSwirlz
reviewed
Jul 18, 2024
| // * Set Splatfest rooms to open participation | ||
| for _, session := range common_globals.Sessions { | ||
| if session.GameMatchmakeSession != nil && session.GameMatchmakeSession.GameMode.Value == 12 { | ||
| session.GameMatchmakeSession.OpenParticipation = types.NewPrimitiveBool(true) |
There was a problem hiding this comment.
iirc you can just set session.GameMatchmakeSession.OpenParticipation.Value to true, might be a smidge faster
There was a problem hiding this comment.
Unfortunately not:
# github.com/PretendoNetwork/splatoon/nex
nex/register_common_secure_server_protocols.go:115:53: cannot use true (untyped bool constant) as *"github.com/PretendoNetwork/nex-go/v2/types".PrimitiveBool value in assignment
You might be thinking of the type refactor; PretendoNetwork/nex-go#56 , which we aren't targeting for this server yet.
There was a problem hiding this comment.
Oh, .Value, I can read. That compiles okay, actually.
Bit of a hack but good enough to make things work for now
Fixes freezes related to Splatfest results upload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3
Changes:
Splatoon marks Fest rooms (type 12) as OpenParticipation=false, making them impossible to matchmake into. Trouble is, we want to matchmake into them, so the teams of a fest can join. Hack around it for now until we have a better understanding of what's meant to be going on here.
Fests need PretendoNetwork/nex-protocols-common-go#40 to work.