Optimize bundles sizes, add csso, fix lighthouse issues

[NeOMakinG]

No description provided.

[Hlavtox]

We need to divide the assets per-module again, so they are not loaded in the bundle if not needed.

[NeOMakinG]

We need to divide the assets per-module again, so they are not loaded in the bundle if not needed.

Seems impossible in the current state of PrestaShop

[Hlavtox]

Why not?

It's all about putting proper css to proper directories:
https://github.com/prestarocket-agence/classic-rocket/tree/develop/modules/productcomments/views

You can even unregister a default asset by putting an empty file there:
https://devdocs.prestashop.com/1.7/themes/getting-started/asset-management/#in-themes

And we should be able to specify what we want to load on which controller by specifiying it in theme.yml:
https://devdocs.prestashop.com/1.7/themes/getting-started/asset-management/#registering-in-themes

[NeOMakinG]

@Hlavtox

CSS files path depends on the module developer choice:

some are inside /css/*.css, some are inside /views/dist/css/*.css, some are inside /public/*.css

We have absolutely no way to make this automatic

And we absolutely have no way to add our own stylesheets depending on the fact that a module is activated and installed inside the current page we're visiting.

Yes, we can register some stylesheets depending on the controller we are, but modules can be moved into different hooks, it's not a reliable way to do this, except for the core styles of the page

[Hlavtox]

Yes, but at least the module CSS will be loaded only on pages where it's needed, not everywhere.

[Hlavtox]

With the way hummingbird is written now, all JS, all CSS, for all modules (even uninstalled) are loaded absolutely everywhere.

[NeOMakinG]

With the way hummingbird is written now, all JS, all CSS, for all modules (even uninstalled) are loaded absolutely everywhere.

Yeah I know, we can improve it and it's almost ready: NeOMakinG@d570e8b

But we can't do it perfectly for sure :(

[NeOMakinG]

@Oksydan wants to take this subject, I'll move it to WIP

[Oksydan]

Assign me 👀