Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pndev shell does not exit after killing ember server with ctrl-c #10

Closed
christophermlne opened this issue Oct 18, 2019 · 1 comment
Closed
Labels
wontfix This will not be worked on

Comments

@christophermlne
Copy link

Steps to reproduce

  • from within the es-student (or es-certification) folder, run pndev start
  • try to quick the ember server after it has started with ctrl-c

Actual

  • shell hangs on message 'Cleaning up...'

Expected

  • shell should exit cleanly
@ghedamat
Copy link
Collaborator

so I did a bunch of research

it is not hanging up and it does exit cleanly

but because of how processes work in UNIX
when you send CTRL+C (which sends the SIGTERM signal) pndev is killed

that in turns kills ember s or forego in rails

but those processes have cleanup routines that run after pndev has already exited because they appear to happen in separate processes that are forked.

Unless we're willing to do a TON of work on signal handling this will be hard to fix

I propose that you just press ENTER once you CTRL+C a pndev start and be ok w/it for now :)

@ghedamat ghedamat added the wontfix This will not be worked on label Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants