Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire up the progress stream to the withProgress API #2600

Open
JustinGrote opened this issue Apr 1, 2020 · 2 comments
Open

Wire up the progress stream to the withProgress API #2600

JustinGrote opened this issue Apr 1, 2020 · 2 comments
Labels
Area-Engine Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.

Comments

@JustinGrote
Copy link
Collaborator

JustinGrote commented Apr 1, 2020

Summary of the new feature
When a script is running, if it emits Progress stream output, that output should be tied to the withProgress API to show a toast of the scripts progress.

Low priority now that psreadline progress works fairly normally, this would be a "good first issue" or "nice to have" level item.

Proposed technical implementation details (optional)

https://github.com/microsoft/vscode-extension-samples/tree/master/progress-sample
image

Previously discussed in #140

@ghost ghost added the Needs: Triage Maintainer attention needed! label Apr 1, 2020
@TylerLeonhardt
Copy link
Member

In the past, we've talked about this but decided against it because it would be different from the Console experience - we generally want the PSIC to behave like the regular console.

Now that there's this full fledged API for progress in LSP, it might be a fun feature add if it looks nice.

Might be kinda tough to implement... but here's the progress code:

https://github.com/PowerShell/PowerShellEditorServices/blob/8c500ee1752201d3c1cc2e5d90f1a2af3b1eb15d/src/PowerShellEditorServices/Services/PowerShellContext/Session/Host/EditorServicesPSHostUserInterface.cs#L591-L666

This would absolutely have to handle nested progress.

@TylerLeonhardt TylerLeonhardt added Area-Engine Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs. and removed Needs: Triage Maintainer attention needed! labels Apr 2, 2020
@SeeminglyScience
Copy link
Collaborator

At the very least a $psEditor API for it would be cool. Doesn't translate super well to other editors though.

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Apr 2, 2020
@SeeminglyScience SeeminglyScience removed the Needs: Maintainer Attention Maintainer attention needed! label Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Engine Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.
Projects
None yet
Development

No branches or pull requests

3 participants