Skip to content

Conversation

@anmenaga
Copy link

@anmenaga anmenaga commented Jul 2, 2024

PR Summary

Fix #445

  1. Fixing a typo in WinPSAdapter which was causing it to always run Get operation regardless of what operation was requested by the dsc.
  2. renamed several local variables in WinPSAdapter to more accurately describe their use.

@anmenaga anmenaga requested review from SteveL-MSFT and tgauth July 2, 2024 22:56
Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test?

@anmenaga anmenaga force-pushed the winpsadapter_fix branch from 0ba0fa9 to 7663c74 Compare July 3, 2024 21:39
@anmenaga
Copy link
Author

anmenaga commented Jul 3, 2024

Added test.

@SteveL-MSFT SteveL-MSFT added this pull request to the merge queue Jul 8, 2024
Merged via the queue into PowerShell:main with commit 1b7ea41 Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows PowerShell not running Set operation

2 participants