Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADDomainTrust: Add 'AllowTrustRecreation' property to opt-in to allow trust recreation #421

Closed
johlju opened this issue Jul 10, 2019 · 0 comments · Fixed by #457
Closed

ADDomainTrust: Add 'AllowTrustRecreation' property to opt-in to allow trust recreation #421

johlju opened this issue Jul 10, 2019 · 0 comments · Fixed by #457
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Jul 10, 2019

In the code for the xADDomainTrust there are a mention that we should add a property to handle if a trust is allowed to be recreated or not.

https://github.com/PowerShell/xActiveDirectory/blob/20a097c69651d38123de4dd7e4057ed480966293/DSCResources/MSFT_xADDomainTrust/MSFT_xADDomainTrust.psm1#L332-L335

The current default is that the resource recreates the trust, so if we ant to add 'AllowTrustRecreation' and the default is $false, that would be a breaking change. It would be preferably that the user have to opt-in to such destructive action since since it can result in service interruption. But if that property would default to true, then there are no breaking change.
@johlju johlju added breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Jul 10, 2019
@johlju johlju changed the title xADDomainTrust: Add 'AllowTrustRecreation' property to opt-in to allow trust recreation ADDomainTrust: Add 'AllowTrustRecreation' property to opt-in to allow trust recreation Jul 28, 2019
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Aug 2, 2019
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Aug 2, 2019
@johlju
Changes to ADDomain
3af6bd5 
- BREAKING CHANGE: A new parameter `AllowTrustRecreation` has been added
  that when set allows a trust to be recreated in scenarios where that
  is required. This way the user have to opt-in to such destructive
  action since since it can result in service interruption (issue dsccommunity#421).
@johlju johlju mentioned this issue Aug 2, 2019
Merged
9 tasks
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Aug 2, 2019
@johlju
Changes to ADDomain
10933b9 
- BREAKING CHANGE: A new parameter `AllowTrustRecreation` has been added
  that when set allows a trust to be recreated in scenarios where that
  is required. This way the user have to opt-in to such destructive
  action since since it can result in service interruption (issue dsccommunity#421).
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Aug 3, 2019
@johlju
Changes to ADDomain
59944fb 
- BREAKING CHANGE: A new parameter `AllowTrustRecreation` has been added
  that when set allows a trust to be recreated in scenarios where that
  is required. This way the user have to opt-in to such destructive
  action since since it can result in service interruption (issue dsccommunity#421).
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Aug 3, 2019
@johlju
Changes to ADDomain
2c54137 
- BREAKING CHANGE: A new parameter `AllowTrustRecreation` has been added
  that when set allows a trust to be recreated in scenarios where that
  is required. This way the user have to opt-in to such destructive
  action since since it can result in service interruption (issue dsccommunity#421).
johlju added a commit that referenced this issue Aug 3, 2019
@johlju
BREAKING CHANGE: ADDomain: Add new parameter AllowTrustRecreation (#457)
2922053 
- Changes to ADDomain
  - BREAKING CHANGE: A new parameter `AllowTrustRecreation` has been added
    that when set allows a trust to be recreated in scenarios where that
    is required. This way the user have to opt-in to such destructive
    action since since it can result in service interruption (issue #421).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BREAKING CHANGE: ADDomain: Add new parameter AllowTrustRecreation johlju/ActiveDirectoryDsc
1 participant
@johlju