Columns with NOT NULL and DEFAULT and serials should not be "required"

[user753]

Environment

• PostgreSQL version: 12
• PostgREST version: 7.0.1
• Operating system: Windows 10

Description of issue

For table

create table user (
    id         serial primary key,
    name       text not null
);

Post method Swagger user model is generated as

"user":{"required":["id","name"]}

Shouldn't required contain only "name"?

[wolfgangwalther]

I agree.

This seems to be wrong:

postgrest/src/PostgREST/OpenAPI.hs

Line 61 in 3f690ec

& required .~ map colName (filter (not . colNullable) cs))

Columns with default value should not be marked as required, even if they have a NOT NULL constraint.

[umkl]

any updates? we need it for deets!

[wolfgangwalther]

@ungarmichael Feel free to open a PR!