Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify casing #60

Open
Twixes opened this issue Jul 2, 2020 · 3 comments
Open

Unify casing #60

Twixes opened this issue Jul 2, 2020 · 3 comments

Comments

@Twixes
Copy link
Collaborator

Twixes commented Jul 2, 2020

Proposal

Currently original parts of the code use snake_case, while newer additions use pascalCase. It's JS convention though to use pascalCase in most cases and it might be a good idea to refactor at least exported things (that users see) with that convention in mind.

Upsides

The current mix doesn't look very professional and might be leaving a poor impression on developers wanting to use PostHog.

Downsides

This maneuver would leave quite a lot of these snake_case parts and nuking them is not really an option at this point, so they'd have to be left functioning, just deprecated – that wouldn't be good for code readability.

@mariusandra
Copy link
Collaborator

Yeah, this is definitely something to do one day! We should have a good test suite before embarking on this journey though.

@posthog-bot
Copy link
Collaborator

This issue hasn't seen activity in two years! If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in two weeks.

@Twixes
Copy link
Collaborator Author

Twixes commented Apr 5, 2023

This is still painfully relevant.

@posthog-bot posthog-bot removed the stale label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants