Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contributor recognition transparency missing from repo #75

Closed
GangGreenTemperTatum opened this issue Jul 16, 2024 · 3 comments
Closed

Comments

@GangGreenTemperTatum
Copy link
Contributor

hello! this is not a code issue, but i was wondering if the portswigger team would be open to creating a contributions wall (example)?

the intent is to showcase contributors in a better light, which is not well apparent from the individual Bambda comments, this also makes it very difficult from a personal standpoint to reference my open-source contributions

example of my prior contributions:

#61 -> code blob -> example blob update since the refactor of directory structure in the repo

tyia!

@Hannah-PortSwigger
Copy link
Contributor

Hi

Could you please provide an example of the contributions wall you are looking for, as it seems you've linked an issue that describes the same thing as what you are looking for?

Taking a look at the contributor page under "Insights", it's quite easy to identify people who've contributed to the repository, as well as see a log of the commits that they have contributed. Additionally, you can easily link directly to your accredited file or formatted README copy.

@GangGreenTemperTatum
Copy link
Contributor Author

GangGreenTemperTatum commented Jul 17, 2024

hey @Hannah-PortSwigger
this is great, but is quite difficult for an interested party (ie employer) checking this and isn't straightforward
i mean, if i had best-case scenario would suggest something like allcontributors which you can CI super easy, which the README.md would look like:

[![All Contributors](https://img.shields.io/badge/all_contributors-1-orange.svg?style=flat-square)](#contributors-)

## Contributors ✨

Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/docs/en/emoji-key)):

<!-- ALL-CONTRIBUTORS-LIST:START - Do not remove or modify this section -->
<!-- prettier-ignore-start -->
<!-- markdownlint-disable -->
<table>
  <tr>
    <td align="center"><a href="https://github.com/octocat"><img src="https://avatars.githubusercontent.com/u/583231?v=4" width="100px;" alt=""/><br /><sub><b>The Octocat</b></sub></a><br /><a href="#code-octocat" title="Code">💻</a></td>
  </tr>
</table>
<!-- markdownlint-enable -->
<!-- prettier-ignore-end -->
<!-- ALL-CONTRIBUTORS-LIST:END -->

This project follows the [all-contributors](https://allcontributors.org) specification. Contributions of any kind welcome!

EDIT another suggestion to append contributor names to the individual bambdas

@Hannah-PortSwigger
Copy link
Contributor

Hi.

Thank you for your feedback.

Currently, we think the level of accreditation on the repository is sufficient. At the moment, it is easy to see the individual contributions a user has made using GitHub's contribution insights. Additionally, users can use the author tag to further surface their contributions to their Bambdas.

If the repository gets busier, to the point where it is difficult to identify an individual user's contributions, we'll be happy to revisit this idea.

If there's anything else we can help with, then please let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants