Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get on Chocolatey (or fix vcpkg) #578

Closed
Bengt opened this issue May 17, 2021 · 7 comments
Closed

Get on Chocolatey (or fix vcpkg) #578

Bengt opened this issue May 17, 2021 · 7 comments
Assignees
Labels
P3 Priority: Normal

Comments

@Bengt
Copy link

Bengt commented May 17, 2021

I am following the advice of GitHub to use chocolatey for installing portaudio in continuous integration:

https://docs.github.com/en/actions/using-github-hosted-runners/customizing-github-hosted-runners

Currently, portaudio package is not available on Chocolatey:

https://community.chocolatey.org/packages?q=portaudio

For easy installation, portaudio should be pre-built in Chocolatey's repository and thus installable like so:

choco install portaudio
@Be-ing
Copy link
Collaborator

Be-ing commented May 18, 2021

PortAudio doesn't do binary releases, or at least it hasn't before. You may consider using vcpkg to build PortAudio from source. I see from the mentioned PR you are using GitHub Actions. vcpkg is already installed in the GitHub Actions VMs. Take a look at the libkeyfinder GitHub Actions workflow file for an example how to use vcpkg with GitHub Actions.

@Bengt
Copy link
Author

Bengt commented May 19, 2021

Thanks for the information. Also thanks for the hint to use vcpkg. - I am still new to GitHub actions and their VMs. Unfortunately, installing PortAudio via vcpkg does not work, either: microsoft/vcpkg#18008

@Be-ing
Copy link
Collaborator

Be-ing commented May 19, 2021

I don't know why that is not working. The upstream vcpkg portaudio package builds fine for me locally on Linux. You may consider using the vcpkg port I wrote for Mixxx using #461. That allows building with ASIO support by using the asio feature flag, for example vcpkg install portaudio[asio].

@Bengt
Copy link
Author

Bengt commented May 21, 2021

Thanks for the hint. The asio feature is however not in the package version in vcpkg's package index, which means I cannot install it just like that:

Run vcpkg update
Using local portfile versions. To update the local portfiles, use `git pull`.
No packages need updating.
Computing installation plan...
Package portaudio does not have a asio feature

Sources:

https://github.com/DFKI-Interactive-Machine-Learning/multisensor-pipeline/pull/46/checks?check_run_id=2639564102
https://github.com/DFKI-Interactive-Machine-Learning/multisensor-pipeline/pull/46/checks?check_run_id=2639564249
https://github.com/DFKI-Interactive-Machine-Learning/multisensor-pipeline/pull/46/checks?check_run_id=2639564201
https://github.com/DFKI-Interactive-Machine-Learning/multisensor-pipeline/pull/46/checks?check_run_id=2639564160

Since I am doing this for a production project, I would rather use the upstream vcpkg. As someone who knows how to write one, could you maybe check the upstream port of PortAudio? When comparing it to your port, I see quite some differences. However, I do not know if they have any significance:

https://github.com/mixxxdj/vcpkg/tree/2.3/overlay/ports/portaudio
https://github.com/microsoft/vcpkg/tree/master/ports/portaudio

@Be-ing
Copy link
Collaborator

Be-ing commented May 21, 2021

I cannot upstream that vcpkg port until #461 is merged and released. The upstream vcpkg port currently has a some hacks around the unconventional ways PortAudio's CMake build system currently works. #461 fixes that.

@RossBencina
Copy link
Collaborator

RossBencina commented Feb 24, 2022

@Be-ing #461 is now merged, what is the status please? If there's still work to do for vcpkg, please make a new ticket to track progress.

@RossBencina RossBencina changed the title Get on Chocolatey Get on Chocolatey (or fix vcpkg) Feb 24, 2022
@RossBencina
Copy link
Collaborator

Thanks for the idea but we don't do packages. We're not going to do Chocolatey ourselves, but someone else could do it. Seems like vcpkg is the available solution though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Priority: Normal
Projects
None yet
Development

No branches or pull requests

3 participants