Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose Github Actions CI artefacts #558

Closed
Nelson-numerical-software opened this issue Apr 25, 2021 · 11 comments
Closed

expose Github Actions CI artefacts #558

Nelson-numerical-software opened this issue Apr 25, 2021 · 11 comments
Labels
CI Continuous Integration including GitHub Actions

Comments

@Nelson-numerical-software

It could be great (specially for Windows platforms) to export Github actions artefacts. (.dll, .lib, .h)

 - uses: actions/upload-artifact@v1
      with:
        name: github-action-artifacts
        path: artifacts/
@philburk
Copy link
Collaborator

This sounds interesting. What do you think would be the primary purpose? Debugging, testing releases, obtaining precompiled binaries?

I found these helpful links:
https://docs.github.com/en/actions/guides/storing-workflow-data-as-artifacts
https://docs.github.com/en/actions/managing-workflow-runs/downloading-workflow-artifacts

@Nelson-numerical-software
Copy link
Author

testing prereleases and precompiled binaries ;)

@philburk
Copy link
Collaborator

We have some other big CI changes merging soon. Let's do this after they merge.

@RossBencina
Copy link
Collaborator

This sounds like "release binaries for windows" by another name. I don't think we should do it. We don't have the resources to support binary builds -- there are too many things that can go wrong.

@Nelson-numerical-software
Copy link
Author

This sounds like "release binaries for windows" by another name. I don't think we should do it. We don't have the resources to support binary builds -- there are too many things that can go wrong.

It is better for the official repository to do this than someone else to do the same in a fork.

Portaudio is a very good library but on Windows, portaudio does not help advanced users on Windows with visual studio.

It is not "easy" to nuild (dependencies) and the most important for users is not to compile portaudio but to try to use it.

Currently, it seems that portaudio does not provide binaries for visual studio and it is a real bottleneck on windows.
If portaudio does not want to support visual studio, please say it officially on your repository, users will search others alternatives.

Thanks for your work on PortAudio (used since more 10 years in some projects)

@dechamps
Copy link
Contributor

dechamps commented May 6, 2021

It is not "easy" to nuild (dependencies)

Really? Unless you want ASIO support, building PortAudio on Windows is a simple as opening the folder in Visual Studio 2019 and hitting "build" (using the built-in CMake support). That's it. Literally. If you can't do that, you won't be able to build an application that uses PortAudio either, anyway.

@Nelson-numerical-software
Copy link
Author

Happy to see that finally portaudio 19.7 is available in vcpkg.

You could add at least in each release a binary version for windows.

An example here from another great project:
https://github.com/libsndfile/libsndfile/releases

@Be-ing
Copy link
Collaborator

Be-ing commented May 9, 2021

This is implemented in #461. I made GitHub Actions artifacts for the directory that CMake installs to.

That said, I only implemented that to verify that the CMake installation step was working as I expected on every OS with every build option. I did not intend for it to be used for publishing release binaries. However, it did come in handy when testing mixxxdj/mixxx#3594 because I was able to download the Windows DLL from GitHub Actions in my Windows VM without setting up a Windows development environment to verify that I had fixed a bug in #461.

@Be-ing
Copy link
Collaborator

Be-ing commented Aug 18, 2021

This can be closed now that #461 was merged.

@Nelson-numerical-software
Copy link
Author

win32 (x86) MSVC target seems to be missing in CI only x64 is available.
Please expose win32 MSVC and x64 artefacts

@RossBencina
Copy link
Collaborator

We will not release build artefacts. Closing.

@RossBencina RossBencina added the CI Continuous Integration including GitHub Actions label Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration including GitHub Actions
Projects
None yet
Development

No branches or pull requests

5 participants