Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make content scrollable when height set to auto and content larger than 100vh #981

Open
chris-rohrer opened this issue Nov 12, 2021 · 3 comments

Comments

@chris-rohrer
Copy link

As far as I can tell, the option to make the content of the pop up scrollable only exists when setting a specific height. I ran into a problem where my content exceeds the screen height on certain screens and clips out of frame with no option to scroll. Setting the container's height to 100% and enabling scrolling in the plugin creates white space on larger screens. I believe this problem would be solved when setting a max height along with enabling auto height and handling the overflow by scrolling.

My quick CSS fix:
.pum-container {
max-height: 100vh;
overflow: auto;
}

@danieliser
Copy link
Member

@chris-rohrer - I'm assuming your using something like Fixed Position? If so try without it. The only other setting that would have an effect here is whether or not the Overlay is Disabled.

Disabling the overlay with a non fixed position popup would result in the overflow of the popup being scrollable with the page.

Enabling the overlay with a non-fixed popup would result in a scrollbar being added to the overlay div, allowing excess lengthy popops to scroll up and down.

When you activate Fixed position though things change a bit. Now the popup is locked in place, so scrolling with the page or overlay is not possible.

Fixed position issues primarily stem from not knowing exact height/width.

We have plans to rewrite our positioning system from scratch, it might be something we can overcome at that time.

Will give your quick fix a check and see if its something we can work in without side effects.

@rampagejoe
Copy link

Will this ever be fixed?
large popups are basically unusable with elementor

@danieliser
Copy link
Member

This was never confirmed as a bug as opposed to a configuration issue.

If the OP was using fixed position & CSS auto height, they would effectively have to add custom CSS to set the height, which defeats using Auto in the first place.

Instead just choose one of the responsive sizes and use the min/max controls for width, then height is auto adjusted and scrollable as desired.

Auto is not really a viable option going into v2, and likely to be removed as it simply doesn't work reliably with many content types. It works as intended though, but the results are rarely what people would actually want/intend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants