Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the correct popup title in the aria-labelledby HTML attribute #1078

Open
marklchaves opened this issue Sep 24, 2024 · 0 comments
Open

Comments

@marklchaves
Copy link
Contributor

marklchaves commented Sep 24, 2024

Describe the feature request

This is related to #1077

After the v1.20.1 patch, I see that esc_attr( $labelledby ) isn’t mangling the title string anymore (b/c the getter is probably returning a string now?). That means popup IDs for popups with titles aren't randomly displayed in the HTML at the bottom of the page anymore.

But I still don’t see the actual popup title in the aria-labelledby HTML attribute when a popup has a title. Attached is what I see in the HTML with the latest patch.

If my popup's title is "My Forms Test Popup 490", shouldn’t that be something like “My Forms Test Popup 490”, for example? Or is that "pum_popup_title_nnn" showing up by design?

When I temporarily removed the esc_attr() call, the aria-labelledby had my valid popup title text.

Thanks! (edited)

Use case

Display the correct popup title in the aria-labelledby HTML attribute.

Example screenshots (if any)

DevTools_-_wildebeest-take_instawp_xyz_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant