Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for SDL_RenderCopyEx #25

Merged
merged 1 commit into from
Dec 2, 2018

Conversation

b-viguier
Copy link
Contributor

@b-viguier b-viguier commented Nov 27, 2018

  • Binded SDL_RenderCopyEx (mostly copied from SDL_RenderCopy code…)
  • Added SDL_FLIP_* constants (needed as an argument for SDL_RenderCopyEx).
  • Modified 007-mouse-events.php example to test it, and demonstrate its usage.

Tell me if I have to improve something 😄 .

I was not sure what to do about tests… Cannot determine if errors are due to my changes or not 😕
Have a nice day!

@santiagolizardo santiagolizardo self-requested a review December 1, 2018 21:50
@santiagolizardo
Copy link
Member

Great to see your contribution @b-viguier ! The build error has been there for a while (I'll take some time this week to fix it) and the code looks good. Merged 👍

@santiagolizardo santiagolizardo merged commit c67eb26 into Ponup:master Dec 2, 2018
@b-viguier b-viguier deleted the feature/SDL_RenderCopyEx branch December 2, 2018 20:01
@b-viguier
Copy link
Contributor Author

Nice 😄
Thank you 👍

@b-viguier b-viguier mentioned this pull request Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants