Skip to content
This repository has been archived by the owner on Sep 7, 2022. It is now read-only.

Clicking on the signin button doesn't work #12

Open
ghost opened this issue Jan 31, 2016 · 5 comments
Open

Clicking on the signin button doesn't work #12

ghost opened this issue Jan 31, 2016 · 5 comments

Comments

@ghost
Copy link

ghost commented Jan 31, 2016

Uncaught TypeError: Cannot read property 'token' of undefined | firebase-auth.html:228

Windows 10, Chrome
@robdodson
Copy link
Contributor

shoot, yeah looks like something changed in firebase-auth. Trying to track it down

@robdodson robdodson mentioned this issue Jan 31, 2016
Closed
@robdodson
Copy link
Contributor

This PR fixes the issue for me. GoogleWebComponents/firebase-element#105
Looks like we need to wait on the upstream fix to come down :\

@ghost
Copy link
Author

ghost commented Jan 31, 2016

Oh well, thank you for having investigated!

@robdodson
Copy link
Contributor

The code change is really small if you want to manually update your bower_components/firebase-element/firebase-auth.html

https://github.com/GoogleWebComponents/firebase-element/pull/106/files

@ghost
Copy link
Author

ghost commented Jan 31, 2016

Oh great, you've been incredibly fast! Thank you again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robdodson