This repository has been archived by the owner on Nov 10, 2022. It is now read-only.
Track more metadata about cleanup passes. #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rictic
force-pushed
the
register-passes
branch
3 times, most recently
from
769c211
to
c46bc13
Compare
|
Whoops, missed this being assigned to me. Is this PR still valid? |
|
Yeah, I'd still like to land it. On Wed, Jan 6, 2016, 12:45 PM Daniel Freedman [email protected]
|
| passes?: CleanupConfig; | ||
| } | ||
| let config: Config = | ||
| JSON.parse(stripJsonComments(fs.readFileSync('config.json', 'utf8'))); |
There was a problem hiding this comment.
I'd like to find another way to accomplish comments for the config file, but I'm fine with this for now, just making a note.
|
LGTM with nit (and rebase). |
Also moves the blacklist into a config file. My thinking here is that we're going to want to expand this config file in the future such that all of the PolymerElements-specific material will live in the config file, making it possible for other folks to use tedium to do README generation, etc.
rictic
force-pushed
the
register-passes
branch
from
c46bc13
to
c6ff1b5
Compare
|
Added a command line flag to specify passes to run. Also cleaned up the remaining awkward Promise.resolve chain. PTAL |
rictic
force-pushed
the
register-passes
branch
from
c6ff1b5
to
3e38f9b
Compare
|
LGTM! |
rictic
added a commit
that referenced
this pull request
Jan 12, 2016
Track more metadata about cleanup passes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also moves the blacklist into a config file. My thinking here is
that we're going to want to expand this config file in the future
such that all of the PolymerElements-specific material will live
in the config file, making it possible for other folks to use
tedium to do README generation, etc.