Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When manual mode is true _animationPlaying is never set to false #132

Open
shedokan opened this issue Apr 12, 2018 · 0 comments · May be fixed by #143
Open

When manual mode is true _animationPlaying is never set to false #132

shedokan opened this issue Apr 12, 2018 · 0 comments · May be fixed by #143

Comments

@shedokan
Copy link

Description

_animationPlaying is never set to false on animation end if manual mode is on.

Expected outcome

It should be set to false once an animation ends.

Actual outcome

It stays as true, and instead of showing the exit animation after the entry one it cancells it.

Steps to reproduce

  1. Put a paper-tooltip element in the page with manual-mode="true".
  2. Have a button that calls playAnimation('entry')
  3. After the animation is finished check the _animationPlaying value
jtagscherer pushed a commit to jtagscherer/paper-tooltip that referenced this issue Oct 27, 2018
Always keep animation end listener active, fixes PolymerElements#132
98e1dcf
@jtagscherer jtagscherer linked a pull request Oct 27, 2018 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix animation end callback in manual mode jtagscherer/paper-tooltip
1 participant
@shedokan